bugfix: copy-instance was not robust enough #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially addresses one source of "nondeterminism" in quilc compilation (see quil-lang#676) that was due to a violation of referential transparency. Specifically, non destructive compilation was not non-destructive enough: compiling the same parsed-program instance twice did not successfuly copy measurement instances deeply, resulting in different outputs from compress-qubits, with downstream consequences.
|
(oh: I commented out the clifford tests b/c they've been failing for a while now and I wanted to sanity check my change, we might consider this PR, and any other wide-range-effect PRs to be blocked until the clifford modules and tests are loading, building, and passing again --- I think its just a quicklisp issue; waiting on an update.) |
|
what a great find |
|
re-enable clifford tests and we can merge |
|
turns out the cliffort tests are failing b/c the fucntion |
|
should be good |
stylewarning
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses one source of "nondeterminism" in quilc compilation (see #676) that was due to a violation of referential transparency.
Specifically, non destructive compilation was not non-destructive enough: compiling the same parsed-program instance twice produced two different outputs. This was because copy-instance did not copy instances of measurement deeply, resulting in different outputs from compress-qubits, with downstream consequences.
This only addresses #676 in those cases where you are not parsing the same raw text-based source everytime you compile. Or equivalently, when you are not rebuilding your
Programobject from pyquil every time.